Generate MAPSEC constants from JSON #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have the names and order of the
MAPSECvalues in region_map_sections.json, so we can generate the constants automatically when we process this file. As a bonus we'll put them in an enum to ensureMAPSEC_NONE/MAPSEC_COUNTwill be updated as values are added or removed.The only necessary changes are to
json_data_rules.mkand to the newregion_map_sections.constants.json.txtfile. The changes toregion_map_sections.jsonandregion_map_sections.json.txtare motivated by pokefirered (to support elements in that JSON file that will only specifyid, and so will only output the constant and not any C data)