Improve the title of the RSS feed #157 #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frontcodelover is attempting to deploy a commit to the Premier Octet Team on Vercel. A member of the Team first needs to authorize it. |
tlenclos
reviewed
Nov 20, 2024
| @@ -8,7 +8,7 @@ export const createFeed = (team: PublicTeamResult, teamSlug: string) => { | |||
| const date = new Date(); | |||
| const ogImage = generateTeamOGUrl(team?.slug || ''); | |||
| const feed = new Feed({ | |||
| title: team!.name, | |||
| title: `Cool stuff from the Web - ${team!.name} - Digest.club`, | |||
There was a problem hiding this comment.
Cool stuff from the Web should not be a hardcoded value, sadly we don't have a way to define a digest feed name in the app since a team can post anything.
tlenclos
requested changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Cool stuff from the Web - ${team!.name} - Digest.clubin feed.ts