A new upload input and fixes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing the 'buroData' data via POST New Model SfilBigFile with a different set of validation Renaming the file after upload complete so the stored file keeps the original name
Disabling the button on backstage area Blocking the model when trying to delete a non empty profile
Propagating changes of profiles to users Fixes #12
Full name instead of first name on users list When the name is empty, displaying some demoted text
Fixes #2 Also, changing the label of the password input accordingly the content of database row.
Some validation (still needing to use the get-text schema) Form updating the validation errors, always
Using the manager at Upload validation for testing.
Created getter for captions on BuroOfficeBoyHelper Handling ajax calls with JsonView (injecting the captions into the Json object) Merging captions when the Json comes with extra captions
Location validation fixed JjMediaController::saveUpload() method fixed
Handling error better Making the image upload to work Added more messages (captions) Fixed the forced model at ajax upload
Now is possible to use the BuroOfficeBoy::addHtmlEmbScript() method inside the layout file, also.
"Try again" link working! Error is rendering properly. The end of the upload is detected correctly.
Also, making the "Remove file" link work
The BuroAjaxUpload already displays message when everything goes ok. Link for downloading data after complete working. Minor re-factoring that removes the need of upload view.
Fixing translations. Filling the hidden input with the uploaded file ID. Triggering the onComplete callback in the right moment.
Showing the filename and proper actions when the form comes already filled. Created a new callback: onLoad The BuroAjaxUpload may receive some extra data on a extra parameter.
Hiding image after reseting the input Adding some space between the image and the control links
Checking if cs parent exists calling Model::exists() instead of testing for Model::$data Simpler way of starting transactions.
daniel-abrahao
added a commit
that referenced
this pull request
Mar 22, 2013
A new upload input and fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great changes on upload input: created a whole new class, using HTML5 api for sending file through XMLHttpRequest. Added progress bar for big files. And fixed error messaging for both inputs (the new, ajax input, and the classic, that uses iframe) (Fixes #1).
Added a CakeSchema for JjMedia.
Changed the BuroOfficeBoyHelper::addHtmlEmbScript() so it works when called at the layout file (outside the view).
Also, a small change on CsContentStreamHolderBehavior that fixes a non documented bug (now the script works even when the primary key is forced on data to be saved for the first time.