Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker image precice/fenics #186

Open
BenjaminRodenberg opened this issue Oct 31, 2024 · 1 comment
Open

Create docker image precice/fenics #186

BenjaminRodenberg opened this issue Oct 31, 2024 · 1 comment
Assignees
Milestone

Comments

@BenjaminRodenberg
Copy link
Member

In #174 I started using the image benjaminrodenberg/fenics. The corresponding dockerfile is provided under https://github.com/precice/fenics-adapter/blob/develop/tools/testing/docker/Dockerfile.

As mentioned by @IshaanDesai in #184 we should host the image to precice/fenics. However, to me currently the workflow is a bit unclear. Should we generally move the corresponding dockerfile to https://github.com/precice/ci-images or is there another good place?

@MakisH any input from the systemtests bubble?

@MakisH
Copy link
Member

MakisH commented Nov 8, 2024

In #174 I started using the image benjaminrodenberg/fenics. The corresponding dockerfile is provided under https://github.com/precice/fenics-adapter/blob/develop/tools/testing/docker/Dockerfile.

This place sounds right to me. For the system tests, we also store the respective Dockerfiles in the tutorials repository.

As mentioned by @IshaanDesai in #184 we should host the image to precice/fenics.

If you want to reuse of expose the image to the world, you can of course publish it to the GitHub container registry. This bypasses the discussion of what should be on Docker Hub and what not. We currently only have images with preCICE itself or its dependencies there.

However, to me currently the workflow is a bit unclear. Should we generally move the corresponding dockerfile to https://github.com/precice/ci-images or is there another good place?

The precice/ci-images repository is only for the images that preCICE (the core library) is using in its CI. However, it is common to get confused about the purpose of this repository, especially given our history with publishing (older) system tests images to Docker Hub.

@MakisH any input from the systemtests bubble?

We don't publish any images for the system tests, but we generate them on demand on the same system, reusing previously built layers. The multi-stage Dockerfile we currently use is stored in https://github.com/precice/tutorials/tree/develop/tools/tests/dockerfiles/ubuntu_2204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants