You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As mentioned by @IshaanDesai in #184 we should host the image to precice/fenics. However, to me currently the workflow is a bit unclear. Should we generally move the corresponding dockerfile to https://github.com/precice/ci-images or is there another good place?
This place sounds right to me. For the system tests, we also store the respective Dockerfiles in the tutorials repository.
As mentioned by @IshaanDesai in #184 we should host the image to precice/fenics.
If you want to reuse of expose the image to the world, you can of course publish it to the GitHub container registry. This bypasses the discussion of what should be on Docker Hub and what not. We currently only have images with preCICE itself or its dependencies there.
However, to me currently the workflow is a bit unclear. Should we generally move the corresponding dockerfile to https://github.com/precice/ci-images or is there another good place?
The precice/ci-images repository is only for the images that preCICE (the core library) is using in its CI. However, it is common to get confused about the purpose of this repository, especially given our history with publishing (older) system tests images to Docker Hub.
In #174 I started using the image
benjaminrodenberg/fenics
. The corresponding dockerfile is provided under https://github.com/precice/fenics-adapter/blob/develop/tools/testing/docker/Dockerfile.As mentioned by @IshaanDesai in #184 we should host the image to
precice/fenics
. However, to me currently the workflow is a bit unclear. Should we generally move the corresponding dockerfile to https://github.com/precice/ci-images or is there another good place?@MakisH any input from the systemtests bubble?
The text was updated successfully, but these errors were encountered: