Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from fenics import * avoids publishing #126

Closed
BenjaminRodenberg opened this issue Apr 15, 2021 · 2 comments · Fixed by #130
Closed

from fenics import * avoids publishing #126

BenjaminRodenberg opened this issue Apr 15, 2021 · 2 comments · Fixed by #130
Assignees
@BenjaminRodenberg
Labels
bug Something isn't working
Milestone
v1.1.1

Comments

@BenjaminRodenberg
Copy link
Member

See https://github.com/precice/fenics-adapter/runs/2354843276

The changes introduced in #120 make fenics a dependency for being able to run setup.py, even if you don't actually need it. This breaks python3 setup.py sdist in our publishing pipeline. A workaround is to install FEniCS, but this is not a solution. We should find a different way to check for FEniCS (or at least find a way that does not influence sdist).
@BenjaminRodenberg BenjaminRodenberg added the bug Something isn't working label Apr 15, 2021
@BenjaminRodenberg BenjaminRodenberg self-assigned this Apr 15, 2021
@BenjaminRodenberg BenjaminRodenberg mentioned this issue Apr 15, 2021
Merged
@BenjaminRodenberg BenjaminRodenberg added this to the v1.1.1 milestone Apr 15, 2021
@BenjaminRodenberg
Copy link
Member Author

Related to the v1.1.0 Release (https://github.com/precice/fenics-adapter/releases/tag/v1.1.0): I will now manually publish the package to PyPI. This allows me to circumvent the problem with the missing fenics.

@BenjaminRodenberg
Copy link
Member Author

Related to #128

BenjaminRodenberg added a commit that referenced this issue Apr 21, 2021
@BenjaminRodenberg
Don't kill installation, if fenics is not found. See #126.
c3ef267
@BenjaminRodenberg BenjaminRodenberg mentioned this issue Apr 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminRodenberg BenjaminRodenberg

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging a pull request may close this issue.

Warn, if FEniCS is not found precice/fenics-adapter
1 participant
@BenjaminRodenberg