Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check number of coupling iterations with HT test #116

Open
BenjaminRodenberg opened this issue Jan 11, 2021 · 2 comments
Open

Check number of coupling iterations with HT test #116

BenjaminRodenberg opened this issue Jan 11, 2021 · 2 comments
Assignees
Milestone

Comments

@BenjaminRodenberg
Copy link
Member

#115 added the HT tutorials as a test. However, one thing is still missing to replace the current systemtests: We should also check the number of required coupling iterations to be able to detect regressions.

Two important questions:

  • Do we actually want to replace the systemtest? See discussion under Is vtk reference output for tests/TestCompose_fe-fe useful? systemtests#267
  • If yes, how much additional complexity do we get here? How much code duplication does this introduce? Currently the systemtests repository bundles certain functionality for several tests (result comparison, docker). Do we need this functionality here?
@uekerman
Copy link
Member

The number of coupling iterations is an ill-conditioned observable and therefore sometimes system dependent. We went through the same pain with an integration test in preCICE. I recommend to not check for this number.

If yes, how much additional complexity do we get here? How much code duplication does this introduce? Currently the systemtests repository bundles certain functionality for several tests (result comparison, docker). Do we need this functionality here?

Let's keep this as minimal as possible. Let's not test things that are already tested in preCICE tests. What we want to test here is the FEniCS adapter. You already have the check against the analytical solution. So the result comparison is not needed in my opinion.

@BenjaminRodenberg
Copy link
Member Author

I did not know that the coupling iterations are that sensitive. From my personal experience checking the number of iterations was quite useful in the past. Here it allowed us to uncover a bugs, if I remember correctly: If initialization is buggy, this often increases the number of iterations, but does not break the code. Without checking the iterations we wouldn't have uncovered this bug. I think I came across a similar situation for my research on waveform iteration, as well.

Therefore, I would like to keep this check. But I agree: One should also not look too closely, especially, if the iterations are system dependent.

@BenjaminRodenberg BenjaminRodenberg added this to the v2.x.x milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants