Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realtime data modules not initialising #12519

Closed
AntonioGargaro opened this issue Nov 28, 2024 · 1 comment · Fixed by #12528
Closed

realtime data modules not initialising #12519

AntonioGargaro opened this issue Nov 28, 2024 · 1 comment · Fixed by #12528
Assignees
Labels

Comments

@AntonioGargaro
Copy link
Contributor

AntonioGargaro commented Nov 28, 2024

Type of issue

Bug

Description

A recent upgrade to v9.18 on our customer's site has stopped initialising the Permutive RTD module.
Site: https://www.techspot.com/community/?pbjs_debug=true

It is logged that our RTD module is not loading:
Screenshot 2024-11-28 at 17 12 57

The module is installed and included:
Screenshot 2024-11-28 at 17 14 28

I performed some debugging of Prebid bundle and found that this line is the culprit as it is empty at the point initSubModules() is called on this line.

The attachRealTimeDataProvider() appears to be called after the initialisation which I'm assuming is because it's an async hook?

I did a little more debugging and found that registering of the submodule happens before the realtime data module inits, so I suspect that it should be registered but just is not.

Steps to reproduce

Visit site: https://www.techspot.com/community/?pbjs_debug=true

Observe the log that the submodule doesn't load.

Expected results

Submodule should load

Actual results

Submodule does not load

Platform details

Other information

Another customer's site on Prenid v9.12 appears to load the submodule correctly.

@dgirardi
Copy link
Collaborator

dgirardi commented Dec 2, 2024

This is caused by processQueue() being called too late. The current sequence of events appears to be:

  1. load prebid
  2. set up prebid (pbjs.que.push(...))
  3. call pbjs.processQueue.

Rearranging it so that it's either 2-1-3 or 1-3-2 should fix it; the issue is with setting up configuration in between. This is because prebid patches que.push when loaded, but runs initialization on processQueue.

It looks to me like we should fix it within Prebid as well, but afaik this never would have worked; are you able to confirm if it's indeed related to the update to 9.18, or the order of events just happened to change with it? The working 9.12 example uses the "standard" approach of calling processQueue immediately after Prebid loads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants