Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp.secure: incorrect detection #12366

Closed
patmmccann opened this issue Oct 24, 2024 · 0 comments
Closed

Imp.secure: incorrect detection #12366

patmmccann opened this issue Oct 24, 2024 · 0 comments
Assignees
Labels

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Oct 24, 2024

Type of issue

Bug

Description

A variety of adapters pass imp.secure depending on window protocol. This is incorrect, as the safeframe is always secure regardless of window. Instead of looking at window, we should look at ortb2Imp.secure || 1

In the case of Yahoo / adtrgt, they take it on adapter config so can fall back to ortb2Imp.secure || 1 after adapter config

ortb converter should set imp.secure to 1 unless publisher has set it

Steps to reproduce

Expected results

Actual results

Platform details

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants