Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistance Needed for IncrementX Instream Video Adapter Integration #12118

Closed
Prebid-Vertoz opened this issue Aug 13, 2024 · 5 comments
Closed

Comments

@Prebid-Vertoz
Copy link
Contributor

Type of issue

Assistance Needed for IncrementX Instream Video Adapter Integration

Description

Dear Prebid Team,

We are currently working on the Prebid video instream adapter for IncrementX. We have successfully integrated the necessary code into our existing adapter, and it is functioning as expected. However, we are encountering an issue where the ad is rendered, but pbjs.getAllWinningBids() is returning an empty result or not indicating a winning bid.

Could you please assist us in resolving this issue?

For your reference, we have created a test page where you can observe the scenario:

https://textfeed.howgeneric.com/Prebid/Instream/IX_instream.html

Thank you in advance for your support.

Steps to reproduce

Test page

https://textfeed.howgeneric.com/Prebid/Instream/IX_instream.html

Expected results

Actual results

Platform details

Other information

@dgirardi
Copy link
Collaborator

I believe this is expected behavior. Prebid considers bids "winning" once they have been rendered, but has no general way to know when an instream video bid has been rendered (it depends on the player).

Publishers can either manually call markWinningBidAsUsed, or use the video module, which manages integration with the player.

@patmmccann patmmccann moved this from Triage to Needs OP in Prebid.js Tactical Issues table Aug 14, 2024
@dgirardi
Copy link
Collaborator

@Prebid-Vertoz is this still an issue?

@Prebid-Vertoz
Copy link
Contributor Author

Prebid-Vertoz commented Aug 29, 2024

@Prebid-Vertoz is this still an issue?

Hello @dgirardi,Thanks for reply.
We’ve tried integrating the Prebid Video Module as per video module but it's not working. Could you advise on integrating it with the test page at (https://textfeed.howgeneric.com/Prebid/Instream/IX_instream.html)

@Prebid-Vertoz
Copy link
Contributor Author

@dgirardi Any update on this?

@patmmccann
Copy link
Collaborator

patmmccann commented Sep 9, 2024

@Prebid-Vertoz we recommend you join our community attend video committee meetings. This issue is not particularly specific; what isn't working? What happens, what do you expect to happen? Have you followed the documentation? "something doesnt work, we're not sure what' is not an issue we can provide continued support on.

getAllWinningBids() is associated with ad units that prebid can render. Prebid doesn't render video units, the player does, so it cannot know what won without the publisher calling the marking function to show that the bid has been rendered.

@patmmccann patmmccann closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants