Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubiconBidAdapter tests: please migrate querystring to URLSearchParams #11795

Closed
dgirardi opened this issue Jun 13, 2024 · 2 comments
Closed
Assignees

Comments

@dgirardi
Copy link
Collaborator

The rubiconBidAdapter tests rely on querystring:

import {parse as parseQuery} from 'querystring';

With 9, this had to be explicitly included as a dependency - probably because it was included indirectly through now-removed other dependencies (https://app.circleci.com/pipelines/github/prebid/Prebid.js/21362/workflows/c1660a29-4ce6-4a7b-8dca-b790cf024784/jobs/38114)

Nowadays parsing query strings can be done without relying on an external library - the tests should be updated to use URLSearchParams.

@dgirardi
Copy link
Collaborator Author

@harpere @robertrmartinez tagging you as I'm not sure you've acknowledged this yet

@robertrmartinez
Copy link
Collaborator

Acking now @dgirardi !

Will get it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

5 participants