Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getConfig cleanup of currency #10656

Open
patmmccann opened this issue Oct 30, 2023 · 0 comments
Open

getConfig cleanup of currency #10656

patmmccann opened this issue Oct 30, 2023 · 0 comments
Assignees

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Oct 30, 2023

Type of issue

getConfig is used by adapters to gather currency.adServerCurrency, currency, and floors.data.currency

Description

getConfig is a poor access point for bidders to a variety of fields, which may be dynamic to an ad unit and no longer match config.

Some examples:

const currency = getConfig('currency.adServerCurrency');

const publisherCurrency = config.getConfig('currency.adServerCurrency') || getValue(bid.params, 'currency') || 'EUR';

I propose these all get cleaned up to look at the request object field cur and that the object is autopopulated by config with the first element of the array being ad server currency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants