Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video setup silent failure mode #10637

Closed
EskelCz opened this issue Oct 23, 2023 · 3 comments
Closed

Video setup silent failure mode #10637

EskelCz opened this issue Oct 23, 2023 · 3 comments
Assignees

Comments

@EskelCz
Copy link
Contributor

EskelCz commented Oct 23, 2023

Type of issue

error handling

Description

When setting up video format to hook up into a player, I have found a failure mode which isn't treated as a failure mode but I think it should be. When the mediaTypes.video.divId doesn't match the video player div id, the video ad is not shown, without any error or warning.

Steps to reproduce

Change divId in adUnit configuration to some non-existent value

Test page

https://stackblitz.com/edit/prebid-video?file=index.html%3AL43

Expected results

Ideally a warning that the player was not found

Actual results

The setup acts as if the ad wasn't supposed to be played at all

Platform details

Prebid 8.17 with a renderAd fix from this PR #10567

Other information

Moved to the separate issue from here: #10505

@EskelCz
Copy link
Contributor Author

EskelCz commented Oct 23, 2023

Additionally, when the divId is wrong in video.providers object, the player breaks completely, also without any error or explanation.
Demo: https://stackblitz.com/edit/prebid-video-2?file=index.html%3AL65-L65

@dgirardi
Copy link
Collaborator

For the OP: #10664

For the second issue: in theory you should get a videoSetupFailed event, but from what I can tell there's no way to access it - event listeners can be attached only after init, but the init itself will fire the error event at a time when there cannot be any listeners. @karimMourra could you help? I'm not sure if I'm missing something.

@karimMourra
Copy link
Collaborator

@EskelCz thanks for reporting and including the demo pages! Those are very helpful!
@dgirardi thanks for the fix on #10664 - The other issue appears to be a race condition where the setupFailure is triggered before the event listeners are attached. I'll try to propose a fix next week.

@dgirardi dgirardi removed their assignment Jun 25, 2024
@EskelCz EskelCz closed this as completed Aug 27, 2024
@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid.js Tactical Issues table Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants