Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minified build name #10583

Closed
EskelCz opened this issue Oct 6, 2023 · 3 comments
Closed

Minified build name #10583

EskelCz opened this issue Oct 6, 2023 · 3 comments

Comments

@EskelCz
Copy link
Contributor

EskelCz commented Oct 6, 2023

Type of issue

Question

Description

It's almost a comically small issue, but could you change the name of the production build (produced by gulp build) to prebid.min.js? I think it's a useful convention. Right now I have to rename it after every build and I would guess I'm not alone. :) The minutes and inefficiencies add up.
Thanks for your consideration.

Expected results

Minified build be named prebid.min.js

Actual results

The name is the same as the development build: prebid.js. Maybe there is some important reason for it that I'm ignorant of. :)
@dgirardi
Copy link
Collaborator

dgirardi commented Oct 6, 2023

Currently you can do gulp build --bundle-name "prebid.min.js". Would that suffice? changing the default is breaking and IMO not worth the hassle.

@patmmccann
Copy link
Collaborator

I agree with @dgirardi

@patmmccann patmmccann closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2023
@EskelCz
Copy link
Contributor Author

EskelCz commented Oct 9, 2023

@dgirardi Ah, that's just what I needed. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EskelCz @patmmccann @dgirardi