From e86dfcf4148c16a00a9899ff38ffdb387b94863c Mon Sep 17 00:00:00 2001
From: Kevin Park <109548315+kevpark02@users.noreply.github.com>
Date: Tue, 10 Oct 2023 12:14:16 -0700
Subject: [PATCH] Underdogmedia Bid Adapter: Update pbTimeout Assignment
 (#10466)

* Update assigning pbTimeout to our payload

* Revert unintended change

* Add appropriate unit tests for timeout
---
 modules/underdogmediaBidAdapter.js                |  2 +-
 test/spec/modules/underdogmediaBidAdapter_spec.js | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/modules/underdogmediaBidAdapter.js b/modules/underdogmediaBidAdapter.js
index 4c2bdfe175f..54b74c7ccd4 100644
--- a/modules/underdogmediaBidAdapter.js
+++ b/modules/underdogmediaBidAdapter.js
@@ -71,7 +71,7 @@ export const spec = {
     let data = {
       dt: 10,
       gdpr: {},
-      pbTimeout: config.getConfig('bidderTimeout'),
+      pbTimeout: +config.getConfig('bidderTimeout') || 3001, // KP: convert to number and if NaN we default to 3001. Particular value to let us know that there was a problem in converting pbTimeout
       pbjsVersion: prebidVersion,
       placements: [],
       ref: deepAccess(bidderRequest, 'refererInfo.page') ? bidderRequest.refererInfo.page : undefined,
diff --git a/test/spec/modules/underdogmediaBidAdapter_spec.js b/test/spec/modules/underdogmediaBidAdapter_spec.js
index 2d7c1f11178..c0e2e8dddce 100644
--- a/test/spec/modules/underdogmediaBidAdapter_spec.js
+++ b/test/spec/modules/underdogmediaBidAdapter_spec.js
@@ -5,6 +5,7 @@ import {
   spec,
   resetUserSync
 } from 'modules/underdogmediaBidAdapter.js';
+import { config } from '../../../src/config';
 
 describe('UnderdogMedia adapter', function () {
   let bidRequests;
@@ -763,6 +764,20 @@ describe('UnderdogMedia adapter', function () {
         expect(request.data.ref).to.equal(undefined);
       });
 
+      it('should have pbTimeout to be 3001 if bidder timeout does not exists', function () {
+        config.setConfig({ bidderTimeout: '' })
+        const request = spec.buildRequests(bidRequests, bidderRequest);
+
+        expect(request.data.pbTimeout).to.equal(3001)
+      })
+
+      it('should have pbTimeout to be a numerical value if bidder timeout is in a string', function () {
+        config.setConfig({ bidderTimeout: '1000' })
+        const request = spec.buildRequests(bidRequests, bidderRequest);
+
+        expect(request.data.pbTimeout).to.equal(1000)
+      })
+
       it('should have pubcid if it exists', function () {
         let bidRequests = [{
           adUnitCode: 'div-gpt-ad-1460505748561-0',