Add support for Django 3.1

[WayneLambert]

When trying to install a celery version greater than 4 to a project,
PipEnv cannot resolve the dependency since setup.py is set to <4.0

It is also clear that the package does not currently support Django 3.1

This commit addresses the following issues:

• Updates the Tox/Travis config to allow for the testing of Django 3.1
  with its supported Python versions (3.6, 3.7, and 3.8)
  See: https://docs.djangoproject.com/en/3.1/faq/install/
• Updates setup.py to have a constraint for celery of <5.0
• A couple of refactoring changes:
  • Replace nested if condition with a ternary operator (conditional
    expression)
  • Test params for truthiness instead of its length
• Ran isort over the project and accepted its sorted imports
• Updates README.rst to have an example Google Analytics code that is
  aligned with the Google docs and a user's actual tracking code.
• Added .vscode to the .gitignore file to help VS Code contributors
• Updated CHANGELOG.rst with the more major points of the change
• Altered Development Status classifier to 5 - Production/Stable.
  This was agreed in PR Update codebase for Django 3 and Python 3.8 #62 by @rudigiesler

I have NOT changed the version number within setup.py. I will let you
do this upon build/release.

[WayneLambert]

Hi,

The build for the PR failed. The following is the pertinent part of the traceback from the Python 3.8 / Django 3.1 config:

  File "/home/travis/build/praekeltfoundation/django-google-analytics/.tox/py38-dj31/lib/python3.8/site-packages/djcelery/admin.py", line 3, in <module>

    from anyjson import loads

ModuleNotFoundError: No module named 'anyjson'

ERROR: InvocationError for command /home/travis/build/praekeltfoundation/django-google-analytics/.tox/py38-dj31/bin/coverage run .tox/py38-dj31/bin/django-admin test (exited with code 1)

___________________________________ summary ____________________________________

ERROR:   py38-dj31: commands failed

Since then, I note on issue #64, @rudigiesler mentioned that version 2.2.5 is the lowest version supported by the package.

Would you like me to submit another PR to supersede this one which updates the travis.yml and tox.ini files to simplify the number of testing configurations before you start to address the actual reason for failure?

Thanks,

Wayne

[rudigiesler]

@WayneLambert Looks good to me. I would add the higher Django version constraint to setup.py though. (currently <3.1)

Happy for us to remove/cleanup testing on any versions that are no longer supported.

Looking at the error, seems like django-celery is to blame: celery/django-celery#568 , it doesn't support celery 4: https://github.com/celery/django-celery/blob/master/setup.py#L184. I'm not sure exactly where it's all being used in this project, but maybe we can remove django-celery and use celery directly, although I do remember changes somewhere with celery that required changes to the configuration, so we might need to set a minimum version for celery.

I'm also happy to have isort added to the CI, to ensure that we don't forget to run it.

[WayneLambert]

Hi @rudigiesler,

I have updated the PR for that change. You're absolutely right - it was an oversight on my part. Of course, the automated build from the PR will obviously still fail.

Yes, I'm more than happy for you guys to update the testing configurations to the supported versions.

Yep, I did think the same with regards to Django Celery. Hopefully it doesn't cause any breakages if you just end up using celery directly.

Good idea about adding isort to the CI.

Thanks,

Wayne

[rudigiesler]

Cleanup PR has been merged: #66

[WayneLambert]

OK, that's great. Thanks.

Following the revision for removing the attempt at making it compatible with Celery <5, the checks have now passed for the PR. Is there anything else required or can this be merged and a new release to PyPI?

[rudigiesler]

@WayneLambert Maybe just remove Add support for Celery 4.x.x from the changelog? Other than that, looks good.

[rudigiesler]

@WayneLambert Release made: https://pypi.org/project/django-google-analytics-app/4.4.2/