Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using unix sockets for safe usage on multi-user machines #42

Closed
Ten0 opened this issue Sep 26, 2023 · 1 comment · Fixed by #66
Closed

Allow using unix sockets for safe usage on multi-user machines #42

Ten0 opened this issue Sep 26, 2023 · 1 comment · Fixed by #66
Labels
enhancement New feature or request

Comments

@Ten0
Copy link

Ten0 commented Sep 26, 2023

On multi-user dev machines (such as is our case), it seems there's no way to prevent one user from sending commands to another user's instance, as it's using a standard TCP port on the machine.
Also, it means the users must agree on which port each of them uses, which might be tedious.

It seems that a solution to both issues would be to allow using unix sockets, which are basically sockets but path-based, supporting file permissions. It seems that using a local file in the user's home directory would naturally propagate that directory's permissions, and avoid conflicts.

@pr2502
Copy link
Owner

pr2502 commented Sep 26, 2023

The reason I've originally written it with TCP sockets is that UNIX sockets don't work on windows and I wanted to make it portable.

If someone wants unix sockets and submits a PR that will allow a unix socket in the listen and connect config options without breaking windows and users who are using tcp sockets and/or are using default config I'd be happy to accept that. We could even make unix sockets the default config on *nix systems.

@pr2502 pr2502 added the enhancement New feature or request label Oct 25, 2023
@pr2502 pr2502 linked a pull request Jun 4, 2024 that will close this issue
10 tasks
@pr2502 pr2502 closed this as completed in #66 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants