-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work well with git branches #18
Comments
You can use |
Oh |
I've looked into this a bit more and as far as I can tell this seems to be a missing feature on the editor side. LSP definies an event https://microsoft.github.io/language-server-protocol/specifications/specification-3-15/#workspace_didChangeWatchedFiles which is about the client telling the server when it detected a file change. I've switched from neovim to vscode to helix now and I've noticed that this was a problem in both neovim and is now in helix, but everything just worked in vscode. A possible workaround for us would be to lie to the server about the client's file watching capability even if the client says it doesn't support it and then do the file watching job for the client entirely (or do nothing if the client supports file watching). |
I think that neovim only notifies when there is a change in files that are open. A git checkout will affect files no open by neovim, so it won't notify anything. |
@xxchan Does this actually work for you when using |
Yes. Just tried again (in vscode) rust-analyzer works well by default. |
Oh, does ra-multiplex break even vscode, that would be unfortunate. It might be (also) caused by server request we ignore in that case. We could also add an exception that server requests are sent unconditionally if there is only one client. |
When I checkout to a different branch and open a file which is only included in that branch, there are errors:
Not sure whether the ra server is usually restarted in this case and whether this can be done by ra-multiplex 🤔
The text was updated successfully, but these errors were encountered: