-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect assignment in case of pointer to alias of slice #243
Comments
erikdubbelboer
added a commit
to erikdubbelboer/ffjson
that referenced
this issue
Sep 6, 2018
When a type is a slice of another type we should use the type name itself and not a slice of the elements of the slice. Fixes pquerna#243
See #244 |
Has anyone verified PR #244 to actually work? |
@andersfylling I have :) but I missed the question for a test case. I'll add this this weekend. |
erikdubbelboer
added a commit
to erikdubbelboer/ffjson
that referenced
this issue
Mar 23, 2019
When a type is a slice of another type we should use the type name itself and not a slice of the elements of the slice. Fixes pquerna#243
@andersfylling I have updated the pull request with a test case. |
This issue is still present in the current master branch, when will the fix be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider following declared types, as found in the github.com/golang/geo/s2 package:
This package is then used in another file as follows:
Running ffjson for this file produces the following code, and no error messages:
j.Cells = &[]s2.CellID{}
However, this produces the following error when building:
The correct code in this case would be
The text was updated successfully, but these errors were encountered: