From 5cdbeea22c17d39427aaa303b44f1b2439f6b259 Mon Sep 17 00:00:00 2001 From: Hanno Becker Date: Tue, 3 Dec 2024 09:12:28 +0000 Subject: [PATCH] Remove TODO regarding unrolling of gen_matrix() Our performance numbers suggest that the unrolling either already works or is not needed, so remove the corresponding TODO. Signed-off-by: Hanno Becker --- mlkem/indcpa.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/mlkem/indcpa.c b/mlkem/indcpa.c index a5ae200dc..46daaf537 100644 --- a/mlkem/indcpa.c +++ b/mlkem/indcpa.c @@ -293,13 +293,6 @@ void gen_matrix(polyvec *a, const uint8_t seed[MLKEM_SYMBYTES], int transposed) memcpy(seedxy[j], seed, MLKEM_SYMBYTES); } - /* - * TODO: All loops in this function should be unrolled for decent - * performance. - * Either add suitable pragmas, or split gen_matrix according to MLKEM_K - * and unroll by hand. - */ - for (i = 0; i < (MLKEM_K * MLKEM_K / KECCAK_WAY) * KECCAK_WAY; i += KECCAK_WAY) {