Fully support Bus Interactions #2184
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 6, 2024
This PR adds a `Constr:: PhantomBusInteraction` variant. For now, it is ignored - if users want to use a bus, they need to express this in terms of phantom lookups / permutations as before this PR. I added a few `TODO(bus_interaction)` and opened #2184 to track support for phantom bus interactions. One use-case this could have before though is to trigger a "hand-written" witness generation for the bus, as discussed in the chat.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #2183, I added a
Constr::PhantomBusInteraction, but so far, it is largely ignored. It should be handled appropriately in the witness solver and the MockBackend.I think the end game would be to unify lookups, permutations and bus interactions, and remove phantom permutations and lookups. This requires generalizing witgen code (and perhaps making some assumptions for now, like that sends and receives can be matched at compile time).
I added a few
TODO(bus_interaction)comments in the codebase to point to areas that need to be touched.The text was updated successfully, but these errors were encountered: