Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bus doesn't work when tuples with next references are passed #2140

Open
georgwiese opened this issue Nov 25, 2024 · 0 comments
Open

Bus doesn't work when tuples with next references are passed #2140

georgwiese opened this issue Nov 25, 2024 · 0 comments

Comments

@georgwiese
Copy link
Collaborator

This is because the accumulator update equation applies the next operator to the tuple sent by the bus, so we get errors like:
Double application of "'" on: main_binary::operation_id
@georgwiese georgwiese mentioned this issue Nov 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 25, 2024
@georgwiese
Remove next references in lookups / permutations (#2141)
e35b478 
Currently, when we run the Goldilocks RISC-V machine with `--linker-mode
bus` results in:

`Double application of "'" on: main_binary::operation_id` because of
#2140. This PR hot-fixes it, so we can run benchmarks using the bus.
Only adds 3 witness columns (1 in binary, 2 in shift).
github-merge-queue bot pushed a commit that referenced this issue Nov 26, 2024
@georgwiese
Remove next references in lookups / permutations (#2141)
f1db48d 
Currently, when we run the Goldilocks RISC-V machine with `--linker-mode
bus` results in:

`Double application of "'" on: main_binary::operation_id` because of
#2140. This PR hot-fixes it, so we can run benchmarks using the bus.
Only adds 3 witness columns (1 in binary, 2 in shift).
leonardoalt pushed a commit that referenced this issue Nov 26, 2024
@georgwiese @leonardoalt
Remove next references in lookups / permutations (#2141)
bfaeff4 
Currently, when we run the Goldilocks RISC-V machine with `--linker-mode
bus` results in:

`Double application of "'" on: main_binary::operation_id` because of
#2140. This PR hot-fixes it, so we can run benchmarks using the bus.
Only adds 3 witness columns (1 in binary, 2 in shift).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@georgwiese