feature: dynamically update maintainer list #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhuangqh <[email protected]>
allencloud
reviewed
Jun 20, 2018
| } | ||
| }) | ||
|
|
||
| maintainers = newestMaintainers |
There was a problem hiding this comment.
If we add a lock in this file, do we have to lock the maintainers variable here? @zhuangqh
There was a problem hiding this comment.
The maintainers variable is under reader-writer race. Did you mean to move the lock to
mutex.Lock()
maintainers = newestMaintainers
mutex.Unlock()
There was a problem hiding this comment.
It seems that I misunderstood what you did.
Signed-off-by: zhuangqh <[email protected]>
|
Could you rebase your code to the latest master? @zhuangqh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhuangqh [email protected]
fixes #17