Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't make some simple yet very important checks before starting the installation process (e.g need permission when using --sytem flag) #464

Open
Mizou04 opened this issue Sep 5, 2023 · 3 comments

Comments

@Mizou04
Copy link

Mizou04 commented Sep 5, 2023

Description

Steps To Reproduce

Steps to reproduce the bug:

  1. $ ruby-install ...
  2. ???

Expected Behavior

Actual Behavior

Environment

$ ruby-install --version
...
$ uname -a
...
$ cc --version
...
$ openssl version
...
@Mizou04 Mizou04 added the bug label Sep 5, 2023
@Mizou04
Copy link
Author

Mizou04 commented Sep 5, 2023

I have a fix for this issue

@postmodern
Copy link
Owner

postmodern commented Sep 5, 2023

@Mizou04 feel free to submit a PR. I'm guessing an extra if [[ ! -w "$install_dir" ]]; then could be added to bin/ruby-install.

@Mizou04
Copy link
Author

Mizou04 commented Sep 5, 2023

actually I modified directly the function responsible for parsing the options so it doesn't need to go the whole stack down to bin/ruby-install, is that ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants