Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic insertion seems not happy #34

Open
Vernal opened this issue Jun 28, 2016 · 2 comments
Open

Automatic insertion seems not happy #34

Vernal opened this issue Jun 28, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@Vernal
Copy link
Contributor

Vernal commented Jun 28, 2016

Confirmed: this guy killed insertion in more themes than it fixed it in.

How about a toggle? We go back to regex insertion with an option to try the alternate method? Default to regex.

@Vernal Vernal added the bug label Jun 28, 2016
@Vernal Vernal added this to the 1.1.6 milestone May 3, 2017
@ronalfy
Copy link
Collaborator

ronalfy commented May 8, 2017

I can definitely see the dilemma. The regex caused more harm though because it stripped out content. I'd like to see more examples of this failing so I can tweak the output better.

@Vernal
Copy link
Contributor Author

Vernal commented May 8, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants