Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deleting / moving nodes that have been previously recorded #85

Closed
hallahan opened this issue Sep 8, 2015 · 4 comments
Closed
Labels
Milestone

Comments

@hallahan
Copy link
Contributor

hallahan commented Sep 8, 2015

There are two approaches:

  1. Just enable deleting nodes that are being created during the current session.
  2. Delete OSM Nodes that are both from the OSM API and that were created in previous sessions. Handle this accordingly.

Obviously, option 1 is easier. Option 2 would require further logic with the ODK Backend (Ona).

Part of POI Sprint tracked by master issue #31

@hallahan hallahan changed the title Handle deleting nodes that have been previously recorded Handle deleting / moving nodes that have been previously recorded Sep 11, 2015
@hallahan
Copy link
Contributor Author

This affects moves too, since a move of a previous edit might be disrupted as well.

@hallahan hallahan added this to the POI milestone Sep 11, 2015
@dalekunce dalekunce added the POSM label Dec 8, 2015
@hallahan
Copy link
Contributor Author

hallahan commented Apr 6, 2016

I'm going to remove the delete functionality altogether in OpenMapKit Android. It doesn't lend well to the ODK workflow. For a full-fledged OSM editor, obviously delete is essential. However, when you're filling out an ODK form, having the response include an OSM edit that is a delete is confusing, because the ODK response is an add, but the contents is a delete.

I think that's too confusing and should not exist. I'm going to take out delete. Deletes should be done on the QA stage in POSM server. When doing a field survey, let's just allow adds and modify.

Also, the ODK Aggregate 1.0 workflow is really only an additive system. ODK 2 will be taking modify and delete and use changesets with the server in a distributed way. Doing this in 1.0 will always be cludgy, and we really don't have to have this anyway (to accomplish what we need).

@hallahan
Copy link
Contributor Author

hallahan commented Apr 6, 2016

See #99

@hallahan
Copy link
Contributor Author

hallahan commented Apr 6, 2016

We're removing delete functionality in the app per #99

@hallahan hallahan closed this as completed Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants