Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'random' POI selected when clicking on background map layer #119

Closed
PaulUithol opened this issue Jan 7, 2016 · 6 comments · Fixed by #145
Closed

'random' POI selected when clicking on background map layer #119

PaulUithol opened this issue Jan 7, 2016 · 6 comments · Fixed by #145
Labels

Comments

@PaulUithol
Copy link

Don't really know how to call this; but what seems to happen:

  1. Have a POI layer active (an OSM one in the screenshot). Background layer doesn't seem to matter; both online and mbtiles behave the same
  2. Click somewhere on the background
  3. A little blue square appear where clicked - with the tagging corresponding to a 'selected' POI somewhere offscreen

I'm putting random in quotes because there does seem to be some logic to it. I can't discover what logic that would be though. It's definitely not the closest one, can be miles away. But it is often the same one

screenshot_2016-01-07-10-16-51
screenshot_2016-01-07-10-27-45

@hallahan
Copy link
Contributor

hallahan commented Jan 9, 2016

Could you send me a link to the exact OSM dataset you have loaded here? I'd like to reproduce this.

@hallahan hallahan added the bug label Jan 9, 2016
@PaulUithol
Copy link
Author

Hi Nick, I get this with any dataset we've tried; different base layer, different POI data, even no POI data present at all but a couple of forms/points already surveyed. But for example, try https://drive.google.com/open?id=0Bx3_hrMYdNwLY3VGaXZrOVRwUDQ

@PaulUithol
Copy link
Author

Occurs with the same data as #121: one form, no osm data, one mbtiles for background.

Form: https://drive.google.com/open?id=0Bx3_hrMYdNwLUV9RZXF6U0pKb1U
Mbtiles: https://drive.google.com/open?id=0Bx3_hrMYdNwLN0taTUJUbXZWdTg

  1. Start a new form, just click on the background layer. The blue box will appear.
  2. Add one POI ('+', '+ add node'). Immediately add another one ('+', '+ add node')
  3. Close the tags window (down arrow next to 'Tags')
  4. Click on the background map somewhere. Blue box, one of the POIs will be selected.

With two, which one gets selected still seems somewhat logical. However, that quickly diminishes when you get more (like the screenshot above).

@PaulUithol
Copy link
Author

@hallahan , any news on this one? It's biting us quite a lot.

@hallahan
Copy link
Contributor

I'll take a look. This is a map renderer issue, and we will be replacing the legacy renderer, most likely soon.

This may be a quick fix, however.

@hallahan
Copy link
Contributor

hallahan commented Apr 6, 2016

Note to self - this would require some sort of buffer around POIs with an intersection check. If this is high priority, pinpoint where that buffer would be put in and figure out LOE (probably higher than we'd like).

hallahan added a commit that referenced this issue Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants