feat:コードチェック機能の実装 #362
Open
feat:コードチェック機能の実装 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying kaniwriter with
|
| Latest commit: |
8529e9e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://811197f5.kaniwriter.pages.dev |
| Branch Preview URL: | https://feat-verify.kaniwriter.pages.dev |
tufusa
requested changes
Dec 19, 2024
| @@ -23,7 +24,7 @@ const enterWriteModeKeyword: Record<Target, RegExp> = { | |||
| } as const; | |||
|
|
|||
| const exitWriteModeKeyword: Record<Target, RegExp> = { | |||
| ESP32: /mrubyc-esp32: End mrbwrite mode/, | |||
| ESP32: /mruby\/c v\d(.\d+)* start/, | |||
| @@ -262,7 +263,11 @@ export class MrubyWriterConnector { | |||
| await this.sendCommand("execute"); | |||
| } | |||
|
|
|||
| return Success.value(null); | |||
| const crc = crc8Calculator(binary); | |||
| const crcRes = writeRes.value.split("+OK")[1]; | |||
There was a problem hiding this comment.
意図が分かりづらいので、"".match(//)を使って正規表現で取得するのがよさそうです。
Suggested change
| const crcRes = writeRes.value.split("+OK")[1]; | |
| const crcRes = writeRes.value.match(/^\+OK (?<hash>[0-9a-zA-Z]+)$/)?.groups?.hash; |
のような感じでしょうか？(テキトーに書いたのでちゃんと検証していません)
Comment on lines
+268
to
+270
| if (crc !== undefined && crcRes !== undefined) | ||
| this.verify(crc, parseInt(crcRes, 16)); | ||
| return Success.value(writeRes.value); |
There was a problem hiding this comment.
crcResがundefinedでないこともそうですが、parseInt(crcRes, 16)がNaNでないことも検証するべきでしょう。crcResが常に数値に変換できるとは限らないからです。
Comment on lines
+500
to
+508
| async verify(culcHash: number, retHash: number) { | ||
| if (culcHash === retHash) { | ||
| this.handleText("\r\n Verify Success\r\n"); | ||
| return true; | ||
| } else { | ||
| this.handleText("\r\n Verify Failed\r\n"); | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
verifyに持たせる機能が少なすぎると思います。バイナリからハッシュ値を作って、verifyコマンドを送信して結果を受けとって検証する一連の流れを抽象化すべきです。
| @@ -2,6 +2,7 @@ import { | |||
| CheckCircleRounded as CheckCircleRoundedIcon, | |||
| Edit as EditIcon, | |||
| Flag as FlagIcon, | |||
| Plagiarism, | |||
There was a problem hiding this comment.
流石にPlagiarism(=盗作)はよくない気がします。Document SearchやData Checkはどうでしょうか？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #295
ページに検証というボタンを追加
押すとverifyをマイコン側へ送信する
書き込み終了時の+DONEを+OK [ハッシュ値]に変更しているマイコンに対しては、書き込んだ時に合わせてコードチェックをするようにした