fix: apply transform to damage before blitting #986
Conversation
There was a problem hiding this comment.
Maybe blit_frame_result shouldn't be taking physical damage, because it copies buffer to buffer?
Yeah, you are absolutely right. Either it should also take a Transform, if it has to work with Physical coordinates for some reason and handle the necessary conversion internally or it should just take Buffer-coordinates (which I think would be the proper solution here).
Feel free to also make a smithay PR or at least open an issue please to track this and start a discussion.
| .to_logical(1) | ||
| .to_buffer(1, output_transform) | ||
| .to_logical(1, Transform::Normal) | ||
| .to_physical(1); |
There was a problem hiding this comment.
Ouch, yeah this is ugly.
I think if would possibly a bit cleaner to transform this already in line 1006 https://github.com/pop-os/cosmic-comp/pull/986/files#diff-85c7861d0290a1e31c47e8e1d31b15f37d2bb03a1b4edb046d9173eef8c9f758R1006 .
But given this is quite a hack anyway, we don't have to bother.
There seems to be something off about the types of damage being passed around for screencopy. The screencopy damage is clipped because it isn't rotated, so for a rotated screen 1920x1080, it becomes 1080x1080 in
blit_frame_resultwhen intersected with the dmabuf geometry. This fix can be tested with pop-os/xdg-desktop-portal-cosmic#105 but this is really just a bandaid. Maybeblit_frame_resultshouldn't be taking physical damage, because it copies buffer to buffer? I think the dmabuf geometry used inblit_frame_resultseems like it should be Buffer too, but I'm not as familiar with smithay.