Fix panic with mirroring #1047
Merged
Fix panic with mirroring #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems cd9ff0b broke mirroring. Though it's also a bug that if any of these if conditions is not met, the data will not be initialized. Fixes pop-os/cosmic-epoch#1341.
Having if conditions for these is unnecessary when they should never be reached. (This is commonly unwrapped in `smithay`.) Some of these else conditions fail to call `data_init.init` with a new id, so they'd result in a crash later anyway.
Drakulix
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pop-os/cosmic-epoch#1341.