Adaptive VRR support #1004
Merged
Adaptive VRR support #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 18, 2024
ids1024
reviewed
Nov 20, 2024
Drakulix
force-pushed
the
vrr
branch
2 times, most recently
from
0f168b4 to
11ba699
Compare
|
|
ids1024
approved these changes
Nov 27, 2024
|
|
||
| pub fn use_adaptive_sync(&mut self, vrr: AdaptiveSync) -> Result<bool> { | ||
| if vrr != AdaptiveSync::Disabled { | ||
| let (tx, rx) = std::sync::mpsc::sync_channel(1); |
There was a problem hiding this comment.
I wish std had a oneshot channel, but I guess it's not worth adding a dependency for it when it's not already in the dependency tree.
Comment on lines
+107
to
+113
| pub enum AdaptiveSync { | ||
| #[serde(rename = "true")] | ||
| Enabled, | ||
| #[serde(rename = "false")] | ||
| Disabled, | ||
| Force, | ||
| } |
There was a problem hiding this comment.
It seems a little odd to use a different terminology (enabled/force vs automatic/always) from the protocol, though it doesn't really matter that much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until cosmic-randr and cosmic-settings are ready