Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tezos Infra Module #922

Closed
wants to merge 3 commits into from
Closed

Conversation

namesty
Copy link
Collaborator

@namesty namesty commented Jun 15, 2022

Closes polywrap/wrap-integrations#52

This PR adds a Tezos blockchain environment, as a default infra module

@namesty namesty requested a review from Niraj-Kamdar June 15, 2022 19:51
@namesty namesty requested a review from dOrgJelli as a code owner June 15, 2022 19:51
@@ -0,0 +1,7 @@
const CMDS = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@namesty I'm confused by how these js modules get used, as I don't see them referenced in the docker-compose.yaml or Dockerfile.

Are they useful to users in some way? If so, how can they access them? Is this something common you think we should do (bundle helper scripts w/ the infra modules)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they do seem unrelated, I'll remove them

Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do tezos have test-env-js like we have for default test-env?

This will be out of scope for this PR but would like to suggest that we should have better way to check whether all the services are started or stopped instead of sleeping for arbitrary time and hope it will be started

@dOrgJelli dOrgJelli changed the base branch from prealpha-dev to origin-dev July 6, 2022 09:05
@dOrgJelli dOrgJelli changed the base branch from origin-dev to origin-0.10-dev October 20, 2022 20:47
@dOrgJelli dOrgJelli changed the base branch from origin-0.10-dev to origin-dev November 15, 2022 19:30
@dOrgJelli
Copy link
Contributor

Going to close this inactivity. Additionally we should publish this within another repo instead of adding it as a baked-in default within the CLI.

@dOrgJelli dOrgJelli closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create tezos test-env as an infra module
5 participants