From fa8197d49e740c794d3dbebdc48df6f4f8a0a96b Mon Sep 17 00:00:00 2001 From: Cem Schemel Date: Fri, 15 Jun 2018 15:31:43 -0600 Subject: [PATCH] Some code cleanup --- lib/glitter/cli.rb | 22 ++++++++-------------- spec/lib/glitter_spec.rb | 1 + 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/lib/glitter/cli.rb b/lib/glitter/cli.rb index 9d7cb3a..75d0fa5 100644 --- a/lib/glitter/cli.rb +++ b/lib/glitter/cli.rb @@ -3,13 +3,13 @@ module Glitter # Command line interface for cutting glitter builds class CLI < Thor - desc "push", "pushes a build to a channel with release notes." - method_option :version, :type => :string, :aliases => "-v", :required => true - method_option :channel, :type => :string, :aliases => "-c", :required => true - method_option :notes, :type => :string, :aliases => "-n" - method_option :force, :type => :boolean, :aliases => "-f" - method_option :bundle_version, :type => :string, :aliases => "-b" - method_option :minimum_system_version, :type => :string, :aliases => "-m" + desc "push", "Pushes a build to a channel with release notes." + method_option :version, :type => :string, :aliases => "-v", :required => true + method_option :channel, :type => :string, :aliases => "-c", :required => true + method_option :notes, :type => :string, :aliases => "-n" + method_option :force, :type => :boolean, :aliases => "-f" + method_option :bundle_version, :type => :string, :aliases => "-b" + method_option :minimum_system_version, :type => :string, :aliases => "-m" def push(executable_path, *asset_paths) release = Release::Sparkle.new(channel, options.version) release.minimum_system_version = options.minimum_system_version @@ -46,12 +46,6 @@ def version puts Glitter::VERSION end - # desc "yank", "remove a build from a release channel" - # method_option :version, :type => :string, :aliases => "-v" - # method_option :channel, :type => :string, :aliases => "-c" - # def yank - # end - private def channel server.channel(options.channel) @@ -61,4 +55,4 @@ def server @server ||= Server.new end end -end \ No newline at end of file +end diff --git a/spec/lib/glitter_spec.rb b/spec/lib/glitter_spec.rb index 81a8d85..361ed90 100644 --- a/spec/lib/glitter_spec.rb +++ b/spec/lib/glitter_spec.rb @@ -6,6 +6,7 @@ Glitter::Server.new end + # Note that running this spec *will* upload a single file to your S3 bucket it "should release to channel" do Glitter::Release::Sparkle.new server.channel('test-channel'), "1.1.2-#{rand}" do |r| r.executable = File.open(__FILE__)