Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Threshold for 2 members Council for external proposal #6828

Open
crystalin opened this issue Jan 14, 2022 · 3 comments · May be fixed by #6924
Open

Invalid Threshold for 2 members Council for external proposal #6828

crystalin opened this issue Jan 14, 2022 · 3 comments · May be fixed by #6924

Comments

@crystalin
Copy link
Contributor

Usually the external proposal button is able to guess the right amount of threshold for the council vote.
However when the number in the council is 2, it fails to send the proposal as it puts a 1 threshold instead of 2 in my case.
@jacogr
Copy link
Member

jacogr commented Jan 14, 2022 •
edited
Loading

It is actually incorrect for all council with even numbers, i.e. threasholds are always calculated on >= instead of > or >= depending on where it sits.

In the case of odd number of council, this always works correctly since it is rounded up, in the case of even number of council members, this doesn't since especially in the case of 50/50 it is divisible.

@polkadot-js-bot
Copy link

This issue has been open for 21 days with no activity and is not labelled as an enhancement. It will be closed in 7 days.

@jacogr jacogr linked a pull request Feb 4, 2022 that will close this issue
Open
@jacogr jacogr added -size-s and removed stale labels Feb 4, 2022
@wilwade
Copy link
Contributor

wilwade commented Jan 18, 2023

Looks like the recent release made this much more important. The vote button is now removed when then threshold is reached. So it is not easy to get to where you can vote 50%+1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure evenly divisible thresholds are adjusted polkadot-js/apps
4 participants
@crystalin @wilwade @jacogr @polkadot-js-bot