Fix auto-renew benchmarks #517
Merged
+217
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cmd bench --runtime coretime-kusama --pallet pallet_broker |
1 similar comment
|
/cmd bench --runtime coretime-kusama --pallet pallet_broker |
|
Can we merge this as-is and generate the weights as part of the release? |
Yes |
bkchr
approved these changes
Jan 7, 2025
acatangiu
approved these changes
Jan 7, 2025
|
Polkadot check migrations needs retriggerring. Or @seadanda to merge main to rerun full CI.. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump broker pallet to fix auto-renew benchmarks. Also remove previous mitigations. Fixes #510
There has been no release with this broken benchmark, therefore the changelog already reflects the changes introduced by this release.
Benchmarks will be run before release