Update to SDK `stable2409-1` #490

pandres95 · 2024-10-19T17:06:02Z

Closes #457
Closes #469

Updating the runtimes to SDK version stable2409-1. CHANGELOG mentions all relevant changes for UI and Walletbuilders.

Checklist

Update SDK to stable2409
Update configuration for relay chains.
Update configuration for system parachains.
Update configuration for emulated chains.
Update configuration for Encointer (see Help wanted).
Update CHANGELOG.
Update SDK to stable2409-1

Dependencies

This PR depends on certain PRs to be merged before it can properly work.

Update foreign asset ids from v3 to v4 #472

Impacts

The success of this PR impacts directly on the feasibility of executing certain issues, or closing certain PRs.

Help wanted

Initially, I request the help of:

@franciscoaguirre to help me correcting the potential conflicts that may arise when foreign assets change to XCMv4.
@acatangiu to help me setting up the Bridge Hubs, as well as adding the respective transition layer (a.k.a. preparing the migrations from fixed Lanes to LegacyLane-based lanes storage).
@clangenb to help me upgrading Encointer.
@Szegoo to check the parameters that changed in Coretime.

- Rename `assigner_on_demand` to `on_demand` (SDK #4706) - [BEEFY] Add runtime support for reporting fork voting (#4522) - `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives` - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - Mock Weights

- Rename `assigner_on_demand` to `on_demand` (SDK #4706) - [BEEFY] Add runtime support for reporting fork voting (SDK #4522) - `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives` - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - Mock Weights

- [Assets] Call implementation for `transfer_all` (SDK #4527) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Tx Payment: drop ED requirements for tx payments with exchangeable asset (SDK #4488) - relax XcmFeeToAccount trait bound on AccountId (SDK #4959)

- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Transfer Polkadot-native assets to Ethereum (SDK #5546) - [stable2049] Backport #5546 (SDK #5710) - `XcmFeeToAccount` -> `SendXcmFeeToAccount`

- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935) - [bridges-v2] Permissionless lanes (SDK #4949) - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Transfer Polkadot-native assets to Ethereum (SDK #5546) - [stable2049] Backport #5546 (SDK #5710) - `XcmFeeToAccount` -> `SendXcmFeeToAccount` - [bh polkadot] minor: replace `DOLLARS` with `UNITS` on `BridgeDeposit` storage type

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

- add possibility to inject non-authorities session-keys in genesis (SDK #5078)

clangenb · 2024-10-21T07:38:52Z

I can probably squeeze it in later this week. 👍

pandres95 · 2024-10-21T07:38:53Z

Opened for review with a small caveat: tests will keep failing, until #472 is merged and can be merged back to this branch.

system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs

system-parachains/bridge-hubs/bridge-hub-polkadot/primitives/src/lib.rs

system-parachains/bridge-hubs/bridge-hub-kusama/src/bridge_to_polkadot_config.rs

franciscoaguirre · 2024-11-05T15:06:13Z

What's the state of this? Only needs reviews?

pandres95 · 2024-11-05T21:30:36Z

Only reviews @franciscoaguirre. There are some "failing" migrations, but the failure is related to the spec version. Once we bump, those errors should disappear.

pandres95 · 2024-11-06T16:33:15Z

/cmd help

github-actions · 2024-11-06T16:35:43Z

Command "help" has started 🚀 See logs here

github-actions · 2024-11-06T16:35:59Z

Command "help" has failed ❌! See logs here

pandres95 · 2024-11-06T18:52:28Z

/cmd --help

github-actions · 2024-11-06T18:54:35Z

Command help:

usage: /cmd  [--help] {bench,fmt} ...

A command runner for polkadot runtimes repo

positional arguments:
  {bench,fmt}  a command to run
    bench      Runs benchmarks
    fmt        Formats code

options:
  --help       help for help if you need some help

### Command 'bench'
usage: /cmd bench [-h] [--continue-on-fail] [--quiet] [--clean]
                  [--runtime [{polkadot,kusama,glutton-kusama,asset-hub-kusama,asset-hub-polkadot,bridge-hub-kusama,bridge-hub-polkadot,collectives-polkadot,coretime-kusama,coretime-polkadot,people-kusama,people-polkadot,encointer-kusama} ...]]
                  [--pallet [PALLET ...]]

options:
  -h, --help            show this help message and exit
  --continue-on-fail    Won't exit(1) on failed command and continue with next
                        steps. Helpful when you want to push at least
                        successful pallets, and then run failed ones
                        separately
  --quiet               Won't print start/end/failed messages in Pull Request
  --clean               Clean up the previous bot's & author's comments in
                        Pull Request which triggered /cmd
  --runtime [{polkadot,kusama,glutton-kusama,asset-hub-kusama,asset-hub-polkadot,bridge-hub-kusama,bridge-hub-polkadot,collectives-polkadot,coretime-kusama,coretime-polkadot,people-kusama,people-polkadot,encointer-kusama} ...]
                        Runtime(s) space separated
  --pallet [PALLET ...]
                        Pallet(s) space separated

**Examples**:

 > runs all benchmarks
 
 /cmd bench
 
 > runs benchmarks for pallet_balances and pallet_multisig for all runtimes which have these pallets
 > --quiet makes it to output nothing to PR but reactions
 
 /cmd bench --pallet pallet_balances pallet_xcm_benchmarks::generic --quiet
 
 > runs bench for all pallets for polkadot runtime and continues even if some benchmarks fail
 
 /cmd bench --runtime polkadot --continue-on-fail 
 
 > does not output anything and cleans up the previous bot's & author command triggering comments in PR 
 
 /cmd bench --runtime polkadot kusama --pallet pallet_balances pallet_multisig --quiet --clean 

 


### Command 'fmt'
usage: /cmd fmt [-h] [--continue-on-fail] [--quiet] [--clean]

options:
  -h, --help          show this help message and exit
  --continue-on-fail  Won't exit(1) on failed command and continue with next
                      steps. Helpful when you want to push at least successful
                      pallets, and then run failed ones separately
  --quiet             Won't print start/end/failed messages in Pull Request
  --clean             Clean up the previous bot's & author's comments in Pull
                      Request which triggered /cmd

CHANGELOG.md

pandres95 · 2024-11-07T02:06:29Z

@SBalaguer @anaelleltd just to mention this PR aims to update the Polkadot SDK version of the runtimes to the latest stable one (stable2409-1).

…n instead of 1.3.4 Also, fixes a broken link.

* add delegated staking to kusama * delegate stake in polkadot * fmt * comment * update delegated staking pallet * fix comment * make slashes go to the treasury * update changelog * fmt

eskimor

LGTM (not an expert on most of the changed code). Someone from bridges should certainly double-check.

bkchr · 2024-11-19T10:38:08Z

system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs


 	type ByteFee = xcm_config::bridging::XcmBridgeHubRouterByteFee;
 	type FeeAsset = xcm_config::bridging::XcmBridgeHubRouterFeeAssetId;
+	// TODO: @bkontur - change to `report_bridge_status` when patched - FAIL-CI


@bkontur will this be done before the release?

Well, the truth is, we missed the last stable202409 patch release on 14.11 with this PR. However, we are targeting the next stable202409 release on 2024-12-12.

Actually, I am working now on small nits/fixes/workarounds for this PR, should be ready today and I will remove this TODO.

this TODO: is removed as a part of pandres95#7

relay/polkadot/src/lib.rs

relay/kusama/src/lib.rs

anaelleltd · 2024-11-20T00:07:29Z

To reviewers:
Please take care to double check this update carefully and advise if there are potential breaking changes or disruptions for ecosystem builders.
If any, please ping @anaelleltd or @SBalaguer in your detailed commentary so that we can notify ecosystem teams with the critical information.

bkontur

partial feedback, still not finished

bkontur · 2024-11-20T09:05:19Z

relay/kusama/src/lib.rs

@@ -380,6 +385,8 @@ impl pallet_mmr::Config for Runtime {
 	type WeightInfo = ();
 	type LeafData = pallet_beefy_mmr::Pallet<Runtime>;
 	type BlockHashProvider = pallet_mmr::DefaultBlockHashProvider<Runtime>;
+	#[cfg(feature = "runtime-benchmarks")]
+	type BenchmarkHelper = ();


Shouldn't this be better like this?
According to the stable2409 branch: https://github.com/paritytech/polkadot-sdk/blob/stable2409/polkadot/runtime/westend/src/lib.rs#L427

Suggested change

type BenchmarkHelper = ();

type BenchmarkHelper = parachains_paras::benchmarking::mmr_setup::MmrSetup<Runtime>;

bkontur · 2024-11-20T09:06:37Z

relay/polkadot/src/lib.rs

@@ -367,6 +372,8 @@ impl pallet_mmr::Config for Runtime {
 	type WeightInfo = ();
 	type LeafData = pallet_beefy_mmr::Pallet<Runtime>;
 	type BlockHashProvider = pallet_mmr::DefaultBlockHashProvider<Runtime>;
+	#[cfg(feature = "runtime-benchmarks")]
+	type BenchmarkHelper = ();


Shouldn't this be better like this?
According to the stable2409 branch: https://github.com/paritytech/polkadot-sdk/blob/stable2409/polkadot/runtime/westend/src/lib.rs#L427

Suggested change

type BenchmarkHelper = ();

type BenchmarkHelper = parachains_paras::benchmarking::mmr_setup::MmrSetup<Runtime>;

bkontur · 2024-11-20T09:39:45Z

system-parachains/bridge-hubs/bridge-hub-kusama/src/bridge_to_polkadot_config.rs

+	// TODO: @acatangiu (bridges-v2) - add `LocalXcmChannelManager` impl - https://github.com/paritytech/parity-bridges-common/issues/3047
+	// @acatangiu


Suggested change

// TODO: @acatangiu (bridges-v2) - add `LocalXcmChannelManager` impl - https://github.com/paritytech/parity-bridges-common/issues/3047

// @acatangiu

// TODO: @bkontur (bridges-v2) - add impl - FAIL-CI

@pandres95 fixed by pandres95#7

bkontur · 2024-11-20T09:41:26Z

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_kusama_config.rs

+	type AllowWithoutBridgeDeposit =
+		RelayOrOtherSystemParachains<AllSiblingSystemParachains, Runtime>;
+
+	// TODO: @acatangiu (bridges-v2) - add `LocalXcmChannelManager` impl - https://github.com/paritytech/parity-bridges-common/issues/3047


Suggested change

// TODO: @acatangiu (bridges-v2) - add `LocalXcmChannelManager` impl - https://github.com/paritytech/parity-bridges-common/issues/3047

// TODO: @bkontur (bridges-v2) - add impl - FAIL-CI

@pandres95 fixed by pandres95#7

bkontur · 2024-11-20T10:22:03Z

system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs

+			// TODO: @bkontur or @acatangiu, please confirm if this chain will be used at all.
 			pub const PolkadotNetwork: NetworkId = NetworkId::Polkadot;
 			pub const EthereumNetwork: NetworkId = NetworkId::Ethereum { chain_id: 1 };
+			// TODO: @bkontur or @acatangiu, please confirm if this should be in the configuration, or if
+			// this `chain_id` is just for testing purposes.


yes, it is used for PolkadotOrEthereumAssetFromAssetHubPolkadot, which means that AHK accepts these locations as trusted reserves

Suggested change

// TODO: @bkontur or @acatangiu, please confirm if this chain will be used at all.

pub const PolkadotNetwork: NetworkId = NetworkId::Polkadot;

pub const EthereumNetwork: NetworkId = NetworkId::Ethereum { chain_id: 1 };

// TODO: @bkontur or @acatangiu, please confirm if this should be in the configuration, or if

// this `chain_id` is just for testing purposes.

pub const PolkadotNetwork: NetworkId = NetworkId::Polkadot;

pub const EthereumNetwork: NetworkId = NetworkId::Ethereum { chain_id: 1 };

bkontur · 2024-11-20T15:24:04Z

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_kusama_config.rs

+	// TODO: @acatangiu, is there any specs about the deposit cost?
+	pub storage BridgeDeposit: Balance = 10 * constants::currency::UNITS;


this TODO is fixed by: pandres95#7

Suggested change

// TODO: @acatangiu, is there any specs about the deposit cost?

pub storage BridgeDeposit: Balance = 10 * constants::currency::UNITS;

bkontur · 2024-11-20T15:25:00Z

system-parachains/bridge-hubs/bridge-hub-kusama/src/bridge_to_polkadot_config.rs

+	// TODO: What's the correct value? - FAIL-CI
+	pub storage BridgeDeposit: Balance = constants::currency::UNITS;


this TODO is fixed by pandres95#7

Suggested change

// TODO: What's the correct value? - FAIL-CI

pub storage BridgeDeposit: Balance = constants::currency::UNITS;

* revert delegate stake configuration in kusama * update pool migrating max count

* Remove unused * Added `LocalXcmChannelManager` for bridges * Fixed `BridgeDeposit` TODO * Compilation fix + don't need to fund system para * fmt

seadanda · 2024-11-20T15:54:16Z

system-parachains/coretime/coretime-kusama/src/coretime.rs

@@ -332,5 +344,7 @@ impl pallet_broker::Config for Runtime {
 	type WeightInfo = weights::pallet_broker::WeightInfo<Runtime>;
 	type PalletId = BrokerPalletId;
 	type AdminOrigin = EnsureRoot<AccountId>;
+	type SovereignAccountOf = SovereignAccountOf;
+	type MaxAutoRenewals = ConstU32<0>;


@Szegoo see pandres95#6

chore(Cargo): update SDK to stable2409

8066fc1

pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 2e8844d to 471ce8d Compare October 19, 2024 17:06

pandres95 changed the title ~~Upgrade to Polkadot SDK stable2409~~ Update to Polkadot SDK stable2409 Oct 19, 2024

pandres95 changed the title ~~Update to Polkadot SDK stable2409~~ Update to SDK stable2409 Oct 19, 2024

pandres95 mentioned this pull request Oct 20, 2024

Migrate all existing foreign assets to XCMv4. #209

Open

pandres95 force-pushed the upgrade-polkadot-stable2409 branch 3 times, most recently from f08d159 to 4b4a252 Compare October 21, 2024 02:23

pandres95 added 13 commits October 20, 2024 21:37

wip(workspace): disable Encointer

0450dd2

feat(system-parachains/collectives): Configure Collectives Polkadot

161bfaf

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

feat(system-parachains/coretime): Configure Coretime Kusama

4ec6e3a

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights

feat(system-parachains/coretime): Configure Coretime Polkadot

44d41a9

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078) - Coretime auto-renew (SDK #4424) - Mock Weights

feat(system-parachains/people): Configure People Kusama

1e0e946

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

feat(system-parachains/people): Configure People Polkadot

62af401

- `XcmFeeToAccount` -> `SendXcmFeeToAccount` - add possibility to inject non-authorities session-keys in genesis (SDK #5078)

change(integration-tests/emulated): Configure Penpal

e0760ad

- add possibility to inject non-authorities session-keys in genesis (SDK #5078)

pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 3d0b758 to e0760ad Compare October 21, 2024 02:45

pandres95 added 3 commits October 21, 2024 02:36

change(system-parachains): adjust tests + minor fixes

715531f

change(integration-tests): minor adjustments

457dab3

fix(relay): missing BenchmarkHelper for pallet_mmr

f2a3fce

pandres95 marked this pull request as ready for review October 21, 2024 07:38

fix(relay/kusama): missing feature propagation

fd15642

bkontur reviewed Oct 21, 2024

View reviewed changes

Ank4n mentioned this pull request Nov 6, 2024

Switch to using Delegation Staking for pools pandres95/runtimes#5

Merged

2 tasks

Ank4n reviewed Nov 6, 2024

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

pandres95 requested a review from Ank4n November 7, 2024 02:05

chore(CHANGELOG): set changes from this PR to the "Unreleased" sectio…

f54a026

…n instead of 1.3.4 Also, fixes a broken link.

pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 5f44fbf to f54a026 Compare November 7, 2024 04:25

Ank4n and others added 2 commits November 9, 2024 08:22

Switch to using Delegation Staking for pools (#5)

cf05416

* add delegated staking to kusama * delegate stake in polkadot * fmt * comment * update delegated staking pallet * fix comment * make slashes go to the treasury * update changelog * fmt

Merge branch 'main' into upgrade-polkadot-stable2409

5767f90

Ank4n approved these changes Nov 18, 2024

View reviewed changes

eskimor approved these changes Nov 18, 2024

View reviewed changes

sandreim approved these changes Nov 19, 2024

View reviewed changes

bkchr approved these changes Nov 19, 2024

View reviewed changes

seadanda mentioned this pull request Nov 19, 2024

[pallet-broker] Fix auto renew benchmarks paritytech/polkadot-sdk#6505

Open

1 task

bkontur reviewed Nov 20, 2024

View reviewed changes

Mitigate coretime auto-renew benchmarked weights issues (#6)

adc262e

bkontur reviewed Nov 20, 2024

View reviewed changes

Ank4n and others added 2 commits November 21, 2024 21:27

Revert changes in Kusama runtime causing bench test failure (#8)

0cc2571

* revert delegate stake configuration in kusama * update pool migrating max count

Bridge fixes for stable2409 (#7)

ac46d87

* Remove unused * Added `LocalXcmChannelManager` for bridges * Fixed `BridgeDeposit` TODO * Compilation fix + don't need to fund system para * fmt

seadanda reviewed Dec 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to SDK `stable2409-1` #490

Update to SDK `stable2409-1` #490

pandres95 commented Oct 19, 2024 •

edited

Loading

clangenb commented Oct 21, 2024

pandres95 commented Oct 21, 2024

franciscoaguirre commented Nov 5, 2024

pandres95 commented Nov 5, 2024

pandres95 commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

pandres95 commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

pandres95 commented Nov 7, 2024

eskimor left a comment

bkchr Nov 19, 2024

bkontur Nov 20, 2024

bkontur Nov 20, 2024

anaelleltd commented Nov 20, 2024

bkontur left a comment

bkontur Nov 20, 2024

bkontur Nov 20, 2024

bkontur Nov 20, 2024

bkontur Nov 20, 2024

bkontur Nov 20, 2024

bkontur Nov 20, 2024

bkontur Nov 20, 2024

bkontur Nov 20, 2024

bkontur Nov 20, 2024

seadanda Nov 20, 2024

	type BenchmarkHelper = ();
	type BenchmarkHelper = parachains_paras::benchmarking::mmr_setup::MmrSetup<Runtime>;

		// TODO: @acatangiu (bridges-v2) - add `LocalXcmChannelManager` impl - https://github.com/paritytech/parity-bridges-common/issues/3047
		// @acatangiu

	// TODO: @acatangiu (bridges-v2) - add `LocalXcmChannelManager` impl - https://github.com/paritytech/parity-bridges-common/issues/3047
	// @acatangiu
	// TODO: @bkontur (bridges-v2) - add impl - FAIL-CI

		// TODO: @acatangiu, is there any specs about the deposit cost?
		pub storage BridgeDeposit: Balance = 10 * constants::currency::UNITS;

		// TODO: What's the correct value? - FAIL-CI
		pub storage BridgeDeposit: Balance = constants::currency::UNITS;

Update to SDK stable2409-1 #490

Are you sure you want to change the base?

Update to SDK stable2409-1 #490

Conversation

pandres95 commented Oct 19, 2024 • edited Loading

Checklist

Dependencies

Impacts

Help wanted

clangenb commented Oct 21, 2024

pandres95 commented Oct 21, 2024

franciscoaguirre commented Nov 5, 2024

pandres95 commented Nov 5, 2024

pandres95 commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

pandres95 commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

pandres95 commented Nov 7, 2024

eskimor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anaelleltd commented Nov 20, 2024

bkontur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Update to SDK `stable2409-1` #490

Update to SDK `stable2409-1` #490

pandres95 commented Oct 19, 2024 •

edited

Loading