Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs: add spec for "when I press enter, the component behaves as expected" #73

Open
jackkoppa opened this issue Jan 29, 2021 · 0 comments
Assignees
Labels
good first issue Good for newcomers tests Improve or add specs

Comments

@jackkoppa
Copy link
Contributor

Per this comment: #71 (comment)

There are a couple things we'll want to test. Right now, SelectMulti.spec.ts only checks for behavior when clicking options. Let's add some initial specs for pressing enter, and lets add them to both SelectMulti.spec.ts and SelectSingle.spec.ts. Things like:

  1. When I press enter on an option, it's selected.
  2. When I press enter on an option, it emits the correct event(s)
  3. (multi) When I press enter on a selected option, it's unselected
  4. (multi) When I press enter not on an option, no event is emitted/nothing happens
  5. (multi) When I press enter while on a selected pill, it's unselected
@jackkoppa jackkoppa added tests Improve or add specs good first issue Good for newcomers labels Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tests Improve or add specs
Projects
None yet
Development

No branches or pull requests

2 participants