Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the crypto module into its own crate #164

Closed
vkomenda opened this issue Jul 24, 2018 · 1 comment
Closed

Move the crypto module into its own crate #164

vkomenda opened this issue Jul 24, 2018 · 1 comment
Assignees

Comments

@vkomenda
Copy link
Contributor

The crypto module

  • has a different commit dynamic to the rest of the hbbft crate,
  • is related to the main code through an interface,
  • has it's own CI tests that add up to the CI tests of hbbft and don't have to be run on every commit to the rest of hbbft.

Separating it into its own crate can also facilitate the research on other types of cryptography (#54) in hbbft because other crates could be designed to use the same interface.

Crypto-related issues such as #89 would move with the module as well.

@c0gent
Copy link
Contributor

c0gent commented Jul 24, 2018

Yes it's a perfect candidate to be separated then. Sounds like it's probably a good idea to move it sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants