Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why is run_one_last_time set to False if callback_by_exception is defined #20

Open
laur89 opened this issue Jun 11, 2021 · 0 comments
Open

Comments

@laur89
Copy link

laur89 commented Jun 11, 2021

See https://github.com/pnpnpn/retry-decorator/blob/master/retry_decorator/retry_decorator.py#L34:
when callback_by_exception is defined and in effect, then run_one_last_time is defaulted to False.

  1. why is it so?
  2. what's the purpose of run_one_last_time to begin with? To be able to swallow exceptions by the retry logic?

In any case, run_one_last_time should always default to True.

laur89 added a commit to laur89/retry-decorator that referenced this issue Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant