Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imageslider breaks on the new Gradio 5 version #35

Open
matemato opened this issue Oct 13, 2024 · 8 comments
Open

Imageslider breaks on the new Gradio 5 version #35

matemato opened this issue Oct 13, 2024 · 8 comments

Comments

@matemato
Copy link

Hi, love your work!

Is there any chance you will be upgrading your implementation of Imageslider so it works on the new version of Gradio? Currently it doesn't work. I tried with numpy images and the display is just empty (but it still works in gradio 4.44).

Thank you so much and appreciate your work!

@MomenSirri
Copy link

I encountered this issue as well. When updating Gradio to a version higher than 4.44, the ImageSlider outputs blank images. This tool is really one of the most important components in all the demos I work on, and I can't exclude it. Thank you for your amazing work, and I hope you'll fix it soon.

@ai-anchorite
Copy link

+1 to this. Any app that manipulates images really requires this awesome slider.
Seems a missed opportunity that it isn't built into Gradio 5 already.

That said, i see there's steps detailed below, so i'll give that a go!

image
gradio-app/gradio#9463

@wbstx
Copy link

wbstx commented Nov 16, 2024

+1 to this. Any app that manipulates images really requires this awesome slider. Seems a missed opportunity that it isn't built into Gradio 5 already.

That said, i see there's steps detailed below, so i'll give that a go!

image gradio-app/gradio#9463

Thanks for pointing this out. Unfortunately, after some investigation, I found that this library can't be directly adapted to Gradio 5 due to some missing functions, particularly the normalise_file function, which is no longer available in Gradio 5. I’m currently working on merging this repo to Gradio 5's template (5.3.0). Some progress here, still quite buggy though.
CCEE608D-5CBE-4D9D-96E1-8D4D008742B9_1_201_a

@pngwn
Copy link
Owner

pngwn commented Nov 16, 2024

I'm almost done with some updates but unfortunately there is a bug with Gradio's custom component CLI which has delayed finalisation and release.

As soon as I have fixed that I should able to finish off and get this out.

@ai-anchorite
Copy link

I'm almost done with some updates but unfortunately there is a bug with Gradio's custom component CLI which has delayed finalisation and release.

As soon as I have fixed that I should able to finish off and get this out.

Very much appreciated.

After working with Gradio5 on a recent video app, it feels a little bad moving back to 4 for image apps. Love those individual resets on the sliders! But ImageSlider is indispensable for displaying background removal or upscaling results etc. So much drama in one component!

@pngwn
Copy link
Owner

pngwn commented Nov 17, 2024

There will be even more drama in the next release too!

@TonyDua
Copy link

TonyDua commented Nov 18, 2024

Need to get an update, thank you for your work @pngwn

@movalex
Copy link

movalex commented Dec 5, 2024

Hey, @pngwn thanks for working on this! Waiting for update too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants