-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an infinite loop blocking bug related to multipart requests #92
Fixed an infinite loop blocking bug related to multipart requests #92
Conversation
Good catch @yawillianpsb if this is the reason. Did you test if everything is working fine using only |
@pmusolino Yes all works fine, except of the request body for multipart/data. All other requests works fine both of them request and response. Without the fix we can't see request body for multipart/form-data anyway. |
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
stream.close() | ||
return data as Data | ||
} | ||
return request.httpBody |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds good to me, at least for the moment since it's better to not show the body rather than send the app in an infinite loop.
I opened a related issue here #93
#38
The problem was an infinite while loop that didn't end.
When multipart request had begun, loop started and blocked all further requests.