Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wormholy is re-enabled when referencing default or ephemeral session configs after being previously disabling #69

Closed
colinhumber opened this issue Oct 26, 2019 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@colinhumber
Copy link
Contributor

colinhumber commented Oct 26, 2019

If I call the Wormholy.enable(_:sessionConfiguration:) to disable logging of network traffic on either the URLSessionConfiguration.default or URLSessionConfiguration.ephemeral, the next time either of those configurations are referenced, Wormholy will re-enable logging for those configurations as the swizzled accessors in NSURLSessionConfiguration+Wormholy automatically enable logging.

As of now, I'm not really sure how to completely disable logging without completely removing the framework.

@colinhumber colinhumber changed the title Wormholy is re-enabled when referencing default or ephemeral session configs after disabling Wormholy is re-enabled when referencing default or ephemeral session configs after being previously disabling Oct 26, 2019
@pmusolino pmusolino added bug Something isn't working help wanted Extra attention is needed labels Oct 30, 2019
@pmusolino
Copy link
Owner

Hi there!
Thanks for discovering this bug.
I think I understand where the problem is, but I'm not able to test it.
Do you have a test project, where can I replicate this issue?

@colinhumber
Copy link
Contributor Author

Sure thing. I've attached a project and commented the affected lines in AppDelegate.swift.
wormholytest.zip

@volbap
Copy link

volbap commented Feb 10, 2021

Hi there, I had the same issue. I just created a pull request that hopefully solves it.

@pmusolino
Copy link
Owner

I released a new (big) version of Wormholy (1.6.5) with some improvements and fixes. https://github.com/pmusolino/Wormholy/releases/tag/1.6.5 Can you test it and let me know if you are still encountering this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants