-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Handle non "project.json" based projects #106
Comments
There doesn't seem to be a way to give a parameters through the extends option so I went an other way.
|
Hi @GuyLescalier, Thanks for the thoughtful issue/PR and sorry for the wait! I'm not familiar with .NET workflows... would you mind providing some more context? Is this something that |
Hi, Yet in So my proposition was to separate the code which is responsible to retrieve those informations. That way you can have multiple implementations for different types of projects. Actualy the best way would be to externalize completely this part instead of having |
Hi again 😄
So maybe that would be the best way to do it. You would have a default "npm based" implementation for the functions that read package metadata. |
Any progress on this? I was looking into making a .NET monorepo :) |
Hi @pmowrer ,
I have used your package for javascript projects and would like to use it for .NET Core projects.
By looking at your code, very few is specific to "project.json" files.
The only dependencies are for locating the file in order to filter the commits and for getting the project name.
I tried to put all those references in a separate file in order to have multiple implementations for different project types :
My problem is I cannot figure out how to retrieve a parameter which would indicate the project type (defaulting to npm for backward compatibility) in order to select the corresponding implementation.
Do you think it is possible and do you have an idea how ?
The text was updated successfully, but these errors were encountered: