Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error overlayer not work when warning #32

Closed
githoniel opened this issue Jan 6, 2020 · 1 comment
Closed

error overlayer not work when warning #32

githoniel opened this issue Jan 6, 2020 · 1 comment

Comments

@githoniel
Copy link

githoniel commented Jan 6, 2020

building error only result in console warning but no error overlayer

I notice in #1 (comment)

I think it works with multiple entry points. The main assumptions to me that would fail in any projects not from CRA would be the custom dev server middlewares and cheap-module-source-map (devtool). It also won't work with resource queries, custom socket implementations nor webpack under proxy servers, but I would consider them as advanced use cases anyhow, and thus will definitely need custom work.

then I'm now using offical webpack-dev-server, with no custom socket implementations, no proxy and using cheap-module-source-map but overlayer still not work

what need to support overlayer? or It only work in CRA project?

Update:

I found that it's because I shoud not expect warning to cause error overlayer after debug。 but there is still a problem

  1. If I turn off webpack-dev-server's overlay, how to display overlayer for warning. because this plugin only display overlayer when error
  2. If I turn on webpack-dev-server's overlay, It will appear two overlayer for errors.

I wonder if the overlay of this plugin is just a replacement of webpack-dev-server, and can we have a options to turn it off and only use webpack-dev-server's built-in overlayer?

@githoniel githoniel changed the title error overlayer no work error overlayer not work Jan 6, 2020
@githoniel githoniel changed the title error overlayer not work error overlayer not work when warning Jan 6, 2020
@githoniel
Copy link
Author

sorry I just found this duplicate with #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant