Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monotonicity API is not consistent #188

Open
fred3m opened this issue Jul 4, 2020 · 0 comments
Open

Monotonicity API is not consistent #188

fred3m opened this issue Jul 4, 2020 · 0 comments

Comments

@fred3m
Copy link
Collaborator

fred3m commented Jul 4, 2020

In setting up the regression tests I was attempting to set the default values for monotonicity from "flat" to "angle" and min_gradient=0.0 (which was the default up until May, except for during initialization). But I noticed that the value passed to the source initialization is not respected by the code, so somewhere there is a break in the argument chain where the user defined value is not making it all the way through to the operator. I was going to fix it as part of the regression testing ticket (DM-25060) but that ticket has gone on long enough, and I'd like to keep the PR simple, so I'm opening this issue to remind us to track down this inconsistency and (preferably) set the default to min_grad=0.0 and monotonicity="angle".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant