Retry on connection open failures #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbuddy
force-pushed
the
retry-on-open-failure
branch
from
ec8592d to
9485e7d
Compare
pmac
approved these changes
Dec 11, 2019
|
@joshbuddy do you think this is ready to go out? A test to make sure the retry exception is raised wouldn't hurt, but it's probably not that big a deal. We'll need to rebase as we just merged #66 . I can also release a version for pre 3.0.0 that would support older Djangos if anyone needs that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hitting an error on
connection.open, we probably prefer to retry with some backoff instead of raising another exception. It's a bit tricky to test, just wanted to run the idea by y'all first.