Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Get review apps env var #18

Open
Blaked84 opened this issue May 11, 2022 · 2 comments
Open

Get review apps env var #18

Blaked84 opened this issue May 11, 2022 · 2 comments

Comments

@Blaked84
Copy link

If an app uses an app.json file with required env var without default value, the app is not created.

I'm working on an update to get the env vars defined for the review apps in the Heroku pipeline and I'll open a PR today.

@pmbanugo
Copy link
Owner

pmbanugo commented May 11, 2022

Can you elaborate more on it? Which version are you using? Value's in app.json are not recognised?

I think the env var should be handled automatically since it's the /review-apps endpoint.

@Blaked84
Copy link
Author

I used the last version (2.0.0-dev).

In my app.json, I don't have default values, only requirement like:

    "MY_ENV_VAR": {
      "required": true
    },

I can retrieve the env var with:
https://github.com/Blaked84/heroku-review-app-actions/blob/main/action.yaml#L54-L63
and
https://github.com/Blaked84/heroku-review-app-actions/blob/main/action.yaml#L76

I can open a PR if this solution is OK for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants