From 3e3d9184d7a3499b2cec55d668a40c445fa32edf Mon Sep 17 00:00:00 2001 From: Loren Gordon Date: Thu, 25 May 2023 08:03:05 -0700 Subject: [PATCH] Updates tests and readme with correct provider/profile configs --- .mergify.yml | 9 ++++----- README.md | 2 +- tests/securityhub_cross_account/main.tf | 2 -- tests/securityhub_same_account/main.tf | 3 +-- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/.mergify.yml b/.mergify.yml index 9ef8ea9..0c77e19 100644 --- a/.mergify.yml +++ b/.mergify.yml @@ -1,15 +1,14 @@ pull_request_rules: - - name: automatic approve dependabot pull requests + - name: approve dependabot pull requests conditions: - - author~=dependabot\[bot\]|dependabot-preview\[bot\] - - status-success=Travis CI - Pull Request + - author=dependabot[bot] actions: review: type: APPROVE - - name: automatic merge dependabot pull requests + - name: merge dependabot pull requests conditions: - - author~=dependabot\[bot\]|dependabot-preview\[bot\] + - author=dependabot[bot] - "#approved-reviews-by>=1" actions: merge: diff --git a/README.md b/README.md index 47c752e..f5a784c 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ the `modules/cross-account-member` module. ## Testing You can find example implementations of this module in the tests folder. This module requires 2 different AWS accounts to test and so the terraform aws provider definitions -are assuming that you will be using a profile with the name `resource-owner` and `resource-member`. +are assuming that you will be using a profile with the name `aws` and `awsalternate`. Note: the implementation `tests/create_securityhub_member` will require you to provide the variables `email_address` prior to use diff --git a/tests/securityhub_cross_account/main.tf b/tests/securityhub_cross_account/main.tf index b6c091f..f79648c 100644 --- a/tests/securityhub_cross_account/main.tf +++ b/tests/securityhub_cross_account/main.tf @@ -1,12 +1,10 @@ # Provider to use as the securityhub member (aka invitee) provider "aws" { - region = "us-east-1" profile = "aws" # Profile must exist in your .aws/config } # Provider to use as the securityhub administrator provider "aws" { - region = "us-east-1" alias = "administrator" profile = "awsalternate" # Profile must exist in your .aws/config } diff --git a/tests/securityhub_same_account/main.tf b/tests/securityhub_same_account/main.tf index 512c14e..5f660e4 100644 --- a/tests/securityhub_same_account/main.tf +++ b/tests/securityhub_same_account/main.tf @@ -1,6 +1,5 @@ provider "aws" { - region = "us-east-1" - profile = "resource-owner" + profile = "aws" # Profile must exist in your .aws/config } module "securityhub" {