Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in document byline #330

Open
mauritsvanrees opened this issue Dec 12, 2022 · 3 comments
Open

Inconsistency in document byline #330

mauritsvanrees opened this issue Dec 12, 2022 · 3 comments

Comments

@mauritsvanrees
Copy link
Member

See https://community.plone.org/t/plone-6-0-0rc2-released/15945/3
The logic plone.app.layout was changed in 2021: #258

You have these two settings:

  • Site Settings: Display publication date, default False. Description: "Show in the byline the date a content item was published."
  • Security Settings: Allow anyone to view 'about' information, default False. Description: "If not selected only logged-in users will be able to view information about who created an item and when it was modified."

If I see it correctly, in Plone 5.2:

  • When you are authenticated, you see the byline.
  • Anonymous does not see the byline, unless "Allow anyone to view 'about' information" is switched on.
  • When "Display publication date" is on, both the publication and modification date are shown, if the viewlet is shown at all.

In the PR for Plone 6.0 the idea seems to have been:

  • It is probably okay for anonymous to view the publication and/or modification date.
  • But site admins should be able to switch off showing the author information to anonymous.

Currently in the code the logic is:

  • When you are authenticated, you see the byline.
  • Anonymous does not see the byline, unless "Display publication date" is switched on.
  • When "Display publication date" is on, only the publication date is shown.
  • Anonymous only sees the author information when "Allow anyone to view 'about' information" is switched on.

So what is missing:

  • The publication should be extra. When "Display publication date" is switched on, both the published and modified dates should be shown. When it is switched off, authenticated users should see the modified date.
  • The descriptions and maybe titles of these settings should be fixed to fit the new logic.

cc @agitator who did this change, and @jensens who approved it. Did I understand the intention correctly?

@petschki
Copy link
Member

petschki commented May 6, 2024

One addition: If "display publication date" is on and the modification date is after publication date, both dates are shown ... see classic demo, when turning on "display publication date"

Bildschirmfoto 2024-05-06 um 16 47 11

@jensens
Copy link
Member

jensens commented May 6, 2024

@mauritsvanrees you are probably right and this could need some improvement.

@yurj
Copy link

yurj commented Oct 31, 2024

let not forget we've also this "byline" with a different logic:
https://github.com/plone/plone.app.contenttypes/blob/e37ec9a297ac8177c5b248171fc9636b16c7a200/plone/app/contenttypes/browser/templates/listing.pt#L91
(checks only views_about and doesn't display creation date)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants