Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform tests compare only first 20 characters #25

Open
thet opened this issue Dec 1, 2017 · 1 comment
Open

transform tests compare only first 20 characters #25

thet opened this issue Dec 1, 2017 · 1 comment

Comments

@thet
Copy link
Member

thet commented Dec 1, 2017

The transform tests only compare the first 20 characters. See:

This is not very much. I wanted to add a case to transform a image with a width option referenced in a rest document but wondered why the tests passed without changing the expected output.
When I remove the 20 character restriction many tests fail.

Probably this is done due to avoid flaky tests which fail as soon as a little change in one of the transform tools was made. But this way we cannot test specific features of the transform tools.

@petschki
Copy link
Member

@thet this is somewhat harder than I thought ... I'm in progress of fixing python2/3 tests (#34) and tried to compare md5 checksums of input/output files, but they differ horribly ... according to this commit eff68f1 the compared chunk got decreased due to wvware troubles ... but maybe you have a better idea how to compare these files so I can try it in my pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants