Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: errors are inconsistent after client-side loading #215

Open
SgtPooki opened this issue Nov 30, 2022 · 0 comments
Open

bug: errors are inconsistent after client-side loading #215

SgtPooki opened this issue Nov 30, 2022 · 0 comments
Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete MVP P1 status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs

Comments

@SgtPooki
Copy link
Contributor

We probably need to move errors to hookState, and make sure everything is using them properly:

Repro

I've got some repro steps for you, but console.error causes nextjs to throw a big annoying banner up :| so you might need to just do this locally:

  1. visit http://localhost:3000/roadmap/github.com/ipfs/ipfs-gui/issues/106#detail (full, new, page load)
  2. click the group header "Theme: Kubo feature parity" (i.e. Theme: Kubo feature parity ipfs/ipfs-gui#121)
  3. click the browser back button

This has consistently resulted in the following screenshot for me, even though loading the issue initially doesn't show these errors.
image
@SgtPooki SgtPooki added bug Something isn't working MVP status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs P1 effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete labels Nov 30, 2022
@SgtPooki SgtPooki added this to Starmap Nov 30, 2022
@SgtPooki SgtPooki moved this to Todo in Starmap Nov 30, 2022
@SgtPooki SgtPooki mentioned this issue Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete MVP P1 status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs
Projects
Starmap
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SgtPooki